fix: LmsHtmlFragment.css not found #1659
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @jciasenza! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1659 +/- ##
==========================================
+ Coverage 90.09% 90.40% +0.31%
==========================================
Files 338 343 +5
Lines 5784 5786 +2
Branches 1370 1347 -23
==========================================
+ Hits 5211 5231 +20
+ Misses 557 538 -19
- Partials 16 17 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @brian-smith-tcril, When you can, tell me what you think about this error? If it's okay for us to do the merge, thanks. |
|
Thanks for the PR @jciasenza! I think this change makes sense and we should land it! @openedx/2u-aurora would any changes need to be made to 2U environments to handle this? It seems none of the |
I think you are right, I was testing it on my development instance, but now I realized that it is repeating the path, so I came up with another solution to make the path absolute with the '//'.
|
brian-smith-tcril
added
the
create-sandbox
|
Sandbox deployment successful 🚀 |
|
Thanks @itsjeyd !!! |
|
Hey @brian-smith-tcril, since you already had a look at this PR would you be able to provide a full review for this PR and merge it when ready? |
itsjeyd
added
the
waiting for eng review
itsjeyd
added
waiting on author
…penedx#1661) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…enedx#1652) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
openedx#1662) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…v2.21.0 (openedx#1664) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…edx#1665) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: abdullahwaheed <[email protected]>
As a follow-up to openedx#1368, remove the UpgradeNotification component from the sidebar's default content.
This will extract more messages to be translated.
Co-authored-by: abdullahwaheed <[email protected]>
…openedx#1684) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Old certificates icons contained edX trademark logos, which were not suitable for the open source repos. Replaced with icons that contain Open edX logos.
Co-authored-by: abdullahwaheed <[email protected]>
…x#1697) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
openedx#1698) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* feat: add additional course end plugin slots * fix: bring plugin slot names in line with new naming scheme * refactor: change plugin files to tsx,remove propTypes * fixup! refactor: change plugin files to tsx,remove propTypes * fixup! fixup! refactor: change plugin files to tsx,remove propTypes * fixup! fixup! fixup! refactor: change plugin files to tsx,remove propTypes * fix: accidentally committed test code * fix: plugin-slot fixes * chore: add ENTERPRISE_LEARNER_PORTAL_URL env var
Co-authored-by: abdullahwaheed <[email protected]>
Several of our plugins still rely on this, though it should be removed ASAP
…x#1707) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: abdullahwaheed <[email protected]>
…x#1710) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…dx#1705) Co-authored-by: Ayesha Waris <[email protected]>
|
Hi Brian, first of all, sorry for the delay. I was on vacation and I'm reviewing the issues. I think this logic for reviewing the protocol might solve it. |
|
Sandbox deployment successful 🚀 |
Description
URL change
Changes Made
I changed the URL call to the Lms Html Fragment.css file, as it was poorly constructed.
On line 18, it used to be called BASE_URL, but it should be LEARNING_BASE_URL.
*Before:
*After:
